feat: add MCP file support for ACP server configuration#214
feat: add MCP file support for ACP server configuration#214
Conversation
|
✅ Preview binaries are ready! To test with modules: |
There was a problem hiding this comment.
Pull request overview
Adds support for supplying MCP server configuration via a JSON file when running the server in experimental ACP transport mode, and passes the filtered MCP server list into the ACP session initialization.
Changes:
- Add
--mcp-fileserver flag (and env var support via Viper) gated behind--experimental-acp. - Load and filter MCP servers from a JSON file based on agent MCP capabilities, and send them in
NewSession. - Add unit/integration tests for MCP config loading/filtering and flag validation behavior.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| x/acpio/acpio.go | Loads MCP config from file, filters unsupported server types, and passes supported MCPs to ACP NewSession. |
| x/acpio/mcp_internal_test.go | Adds internal unit tests for MCP config loading and capability-based filtering. |
| x/acpio/acpio_test.go | Updates NewWithPipes test helper call for new MCP file path parameter. |
| lib/httpapi/setup.go | Plumbs MCP file path through SetupACPConfig into acpio.NewWithPipes. |
| cmd/server/server.go | Introduces --mcp-file flag, validates it requires --experimental-acp, and passes it into ACP setup. |
| cmd/server/server_test.go | Adds tests asserting the new flag can be set via default/CLI/env var and precedence rules. |
| e2e/echo_test.go | Adds integration coverage ensuring --mcp-file fails without --experimental-acp. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…t and improve error messages
…on logic for ACP format
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…update JSON structure
No description provided.